feat(odyssey-react-mui): add overline typography variant #2349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlister-okta
previously approved these changes
Sep 16, 2024
| }, | ||
| render: (args) => <Overline {...args} children={args.children} />, | ||
| play: async ({}) => { | ||
| await axeRun("Typopgraphy Overline"); |
There was a problem hiding this comment.
Suggested change
| await axeRun("Typopgraphy Overline"); | |
| await axeRun("Typography Overline"); |
| }, | ||
| render: (args) => <Legend {...args} children={args.children} />, | ||
| play: async ({}) => { | ||
| await axeRun("Typopgraphy legend"); |
There was a problem hiding this comment.
Suggested change
| await axeRun("Typopgraphy legend"); | |
| await axeRun("Typography legend"); |
Comment on lines
3129
to
3127
| "html:lang(en) &": { | ||
| textTransform: "uppercase", | ||
| }, | ||
|
|
||
| "html:lang(en-*) &": { | ||
| textTransform: "uppercase", | ||
| }, |
There was a problem hiding this comment.
Do we want this instead since we always want these to share changes?
Suggested change
| "html:lang(en) &": { | |
| textTransform: "uppercase", | |
| }, | |
| "html:lang(en-*) &": { | |
| textTransform: "uppercase", | |
| }, | |
| "html:lang(en) &, html:lang(en-*) &": { | |
| textTransform: "uppercase", | |
| }, |
There was a problem hiding this comment.
@KevinGhadyani-Okta Strangely, this doesn't work. I had to make 2 declarations for this to work correctly. I don't know why
There was a problem hiding this comment.
I tried to combine these selectors in quite a few ways to get it working. No luck
| import { Typography } from "./Typography"; | ||
|
|
||
| describe("Typography", () => { | ||
| test("renders overline", () => { |
There was a problem hiding this comment.
Suggested change
| test("renders overline", () => { | |
| test("renders Overline", () => { |
KevinGhadyani-Okta
previously approved these changes
Sep 17, 2024
@KevinGhadyani-Okta Where do we find the Storybook preview URL now? |
jordankoschei-okta
approved these changes
Sep 25, 2024
bryancunningham-okta
force-pushed
the
bc-add-overline-typography
branch
from
41dd73e
to
2ca80a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OKTA-803564
Summary
Overlinetypography componentTesting & Screenshots